SubstringOrDefault: a String Extension Method

Some time ago, I had a need for a String.Substring method in C# that could handle the case where the substring being requested started after the length of the string, or where the substring length was going to exceed the remaining length of the string.

I wanted it to fail gracefully: return an empty string in the first case, and in the second case, return as long a substring as it could. (The default Substring method will throw an exception in both cases.)

In the spirit of LINQ methods like SingleOrDefault(), which return Null if there is no data to return, I offer the following extension methods:

namespace System
{
    public static class ExtensionMethods
    {
        public static string SubstringOrDefault(this string s, int start, int length)
        {
            if (s == null)
                return null;
            if (start < 0)
                return string.Empty;
            if (length == 0)
                return string.Empty;
            if (start > s.Length)
                return string.Empty;
            if (length == -1)
                return s.Substring(start);
            if (start + length > s.Length)
                return s.Substring(start);
            return s.Substring(start, length);
        }

        public static string SubstringOrDefault(this string s, int start)
        {
            return SubstringOrDefault(s, start, -1);
        }

        public static string LeftOrDefault(this string s, int length)
        {
            return SubstringOrDefault(s, 0, length);
        }

        public static string RightOrDefault(this string s, int length)
        {
            if (s == null)
                return null;
            if (length > s.Length)
                return s;
            return SubstringOrDefault(s, s.Length - length, length);
        }

    }

}

Careful readers will note that I threw in two helper methods as well: LeftOrDefault and RightOrDefault. I've always been a little surprised there were no Left or Right methods on String.

Every Table Related to My Table, Recursively

Someone asked me a few months ago how they could find every table in a database that was related to one particular table.  They wanted to know what tables referenced this table via foreign keys, what tables referenced the referencing tables, and so on, from 1 to n.

There’s meta data in SQL Server that can help you do this.  Here’s a SQL statement that will find (and number by distance from the original table) all the foreign keys that reference the table, all the tables that reference that table, etc.

;

 WITH fkey 

 as (

      select   constraint_id = f.object_id

        ,      constraint_name = f.name

        ,      parent_object_id

        ,      parent_name = object_name(f.parent_object_id)

        ,      referenced_object_id

        ,      referenced_object_name = object_name(f.referenced_object_id)

      from     sys.foreign_keys f

 )

 ,  recurse

 as (

      select   depth = 1

         ,     *

      from     fkey

      where    referenced_object_name = 'myTable'  -- <-- use this to filter results.

      union all

      select   depth = recurse.depth + 1

        ,      fkey.*

      from     fkey

         join  recurse 

            on fkey.referenced_object_id = recurse.parent_object_id

 )

 ,  recurseWithFields

 as (

      select   r.*

            ,  parent_column_id

            ,  parent_column_name = p_ac.name

            ,  referenced_column_id

            ,  reference_column_name = r_ac.name

      from     recurse r

          join sys.foreign_key_columns fc

            on r.constraint_id = fc.constraint_object_id

          join sys.all_columns p_ac

            on fc.parent_column_id = p_ac.column_id

            and fc.parent_object_id = p_ac.object_id

          join sys.all_columns r_ac

            on  fc.referenced_column_id = r_ac.column_id

            and fc.referenced_object_id = r_ac.object_id

 )

 select *

 from   recurseWithFields

This will work – but bear in mind that this a list of tables that reference “MyTable”, and doesn’t include tables that “MyTable” references.  To get a list of all tables that reference “MyTable” and vice-versa, recursively, you’d have to do this differently.

If you’d like to see that, let me know:  I can work on that.

A Common Misconception

I see this pattern a lot, particularly on Stack Overflow but also in some of the apps I'm maintaining.

DataSet ds = new DataSet();
ds = dataLayer.GetExampleData();

I was puzzled as to why the programmer would initialize a variable to a new object instance when the very next step is to set the variable to something else.  The DataSet created in the first line is thrown away and never used.  It seems mildly counter-productive.

But I think I’ve figured it out.  The programmer must have been under the impression that when a variable is set to the result of a method, and that method returns null, the variable retains its previous value. 

That isn’t true.

Let me restate that for emphasis:  THIS ISN’T TRUE.  When you set a value to the result of a method call, your variable is set to whatever that method call returns.  If the method call returns null, your variable is now set to null.   Period.  End of story.

I don’t know a language that works otherwise, although I’m sure (this being a big universe) that there must be one or two that do.   The key point, though, is:  THIS ISN’T HOW C# WORKS. 

Bad Idea Challenge #3

This looks like okay code, doesn’t it?

   public IEnumerable<County> GetCounties(int stateId)
   {
       using (var ef = new TopologyEntities())
       {
           return ef.Counties.Where(c => c.stateId == stateId);
       }            
   }

After all, it’s using the using pattern with the IDisposable-implementing EF data context.   Isn’t that what you’re supposed to do?

But:  the following code will throw an error. 

       var counties = GetCounties(10);
       var count = counties.Count();

Do you see why?

(For bonus points) Which line of this code will throw the exception? Why?

Useful Things to Know, #430: Casting to an Enum

We’re all familiar with defining an Enum.  In C#, they look like this:

public enum States
{
    Open,
    InUse,
    Closed
}

It’s understood by most people that Enum values are an alternate way of representing numeric constants.  Sometimes this is made explicit, as in the following:

public enum States
{
    Open = 1,
    InUse  = 2,
    Closed = 3
}

So when you assign to a value of type States, Intellisense will offer you a choice of three values:  States.Open, States.InUse, and States.Closed.

Are those the only values a variable of type States can have?

Actually, no. 

You can assign any integer to variable of an Enum, regardless of whether it’s defined as one of the available constants.  With the example above, the following:

States state = (States) 35;

… would be perfectly fine. Neither the compiler nor the runtime prevent this from happening.

So if your code looked like this:

if(state == States.Open)
{ 
   // do something
}
else if (state == States.InUse)
{
   // do something else

}
else {
   // assume the value must be States.Closed
}

… you have a potential bug. 

Bad Idea Challenge #2

Consider the following database table:

CREATE TABLE Code
(
  Code char(4) PRIMARY KEY
  Description varchar(50)
)

It’s a brand new table in a database nobody is using but you.  You add it to an Entity Framework model and add a value to it, as in this test:

using(Model1DataContext dc = new Model1DataContext())
{
  // Verify the table is empty:
  Assert.AreEqual(0, dc.Codes.Count());

  // Add and save a new record:
  Code rcd = new Code() { Code = "X", Description = "A description" };
  dc.Codes.Add(rcd);
  dc.SaveChanges();

  // That was one record. How many records do you think get returned?
  Assert.AreEqual(1, dc.Codes.Count());
}

Surprise:  you’ll get 2 records back. 

Do you see why?

Hint:  if you inspect the two records, they’ll look superficially the same.  But there’ll be one key (ahem) difference. 

ETA:  No, the semantic key is not the Bad Idea.  But you’re close. 

On sitting down with a new stack of books

The danger of reading programming books is that you may well learn you have been diligently doing the wrong things.

That can sting.  But the danger of NOT reading programming books is that you might never find that out.

Embrace the buzzsaw.  Keep reading.